This repository was archived by the owner on Apr 22, 2023. It is now read-only.
getDiffieHellman: returns a well known, predefined RFC groups#2638
Closed
thinred wants to merge 2 commits intonodejs:masterfrom
Closed
getDiffieHellman: returns a well known, predefined RFC groups#2638thinred wants to merge 2 commits intonodejs:masterfrom
thinred wants to merge 2 commits intonodejs:masterfrom
Conversation
Member
|
Thanks, Tomasz. Sorry for the delay, got kind of backlogged. I'll merge it but can you sign the CLA first? Are you up for writing the documentation for this? |
Author
|
I've signed CLA and yes, I can write docs. However, this won't happen before this evening... :) Tomek |
Author
|
Well, I couldn't wait. Done. |
Member
|
Thanks Tomasz, merged in c6a04ce. |
Author
|
Just to make it complete, here is the code I've used to generate headers: https://gist.github.com/1899353 . Thanks! |
|
Thanks very much thinred! A question of me at SO: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Okay, here come the tests and my approach to issue #2338. The only issue here is that they take ~ 4 seconds to complete (because the groups are huge).
I may provide the Python script used to create the header file and hashes for the tests, if you need it.