connection.destroy() during http req setTimeout() causes TypeError

[s3u]

var clientReq = http.request(options, function (clientRes) {
    ...
});
clientReq.setTimeout(1000, function () {
    clientReq.connection.destroy();
    ...
});

causes

TypeError: Cannot call method 'emit' of null
   at Socket.<anonymous> (http.js:1163:11)
   at Socket.emit (events.js:67:17)
   at Array.1 (net.js:301:14)
   at EventEmitter._tickCallback (node.js:192:40)

This is a regression in v0.6.17. This does not happen in v0.6.16.

[mscdex]

This:

clientReq.setTimeout(1000, function () {
    clientReq.connection.destroy();
    ...
});

should be:

clientReq.setTimeout(function () {
    clientReq.connection.destroy();
    ...
}, 1000);

[s3u]

Which setTimeout are you referring to?

Per http://nodejs.org/api/net.html#socket.setTimeout,

socket.setTimeout(timeout, [callback])

[mscdex]

Ah ok, I didn't realize the order was reversed for socket setTimeout.

[rdzar]

Doesn't timeout already destroy the connection? (I know it says it doesn't in the documentation, haha)
https://github.com/joyent/node/blob/master/lib/http.js#L1518

[m@vm vm]# node run.http.js
callback: timeout
emit: error
emit: close

Because close gets emitted too.

[s3u]

True, I missed that. I guess the refactoring that went into 0.6.17 makes this explicit.

[bnoordhuis]

@s3u Can you post a complete test case?

[quartzjer]

I'm encountering this in production on heroku as well now, reverting to 0.6.16 in the interim.

[bnoordhuis]

Failing test case added in e02af94.

[s3u]

@bnoordhuis Thanks. Was just to submit one.

[bnoordhuis]

@s3u Can you check if b4fbf6d resolves your issue?

[s3u]

@bnoordhuis it does. Thanks.

[bnoordhuis]

Great, thanks for testing.