Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

Commit

Permalink
build: include postmortem symbols on linux
Browse files Browse the repository at this point in the history
Previously we were building the symbols, but the linker was garbage
collecting the symbols because they weren't used. Inform the linker
that we want to keep all symbols from v8 around.
  • Loading branch information
tjfontaine committed Dec 2, 2013
1 parent fcfaa39 commit 6877e64
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 1 deletion.
4 changes: 3 additions & 1 deletion common.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -79,10 +79,12 @@
],
}],
['OS=="solaris"', {
'cflags': [ '-fno-omit-frame-pointer' ],
# pull in V8's postmortem metadata
'ldflags': [ '-Wl,-z,allextract' ]
}],
['OS!="mac" and OS!="win"', {
'cflags': [ '-fno-omit-frame-pointer' ],

This comment has been minimized.

Copy link
@egorse

egorse Jan 27, 2014

D'oh! This broke arm build :S
Meanwhile the 'OS!="mac" and OS!="win" and target_arch!="arm"' @ 85 brings it back to life.

This comment has been minimized.

Copy link
@trevnorris

trevnorris Feb 5, 2014

@tjfontaine any thoughts?

}],
],
'msvs_settings': {
'VCCLCompilerTool': {
Expand Down
6 changes: 6 additions & 0 deletions node.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -290,6 +290,12 @@
'PLATFORM="sunos"',
],
}],
[
'OS=="linux"', {
'ldflags': [
'-Wl,--whole-archive <(PRODUCT_DIR)/obj.target/deps/v8/tools/gyp/libv8_base.a -Wl,--no-whole-archive',
],
}],
],
'msvs_settings': {
'VCLinkerTool': {
Expand Down

0 comments on commit 6877e64

Please sign in to comment.