This repository was archived by the owner on Jun 18, 2021. It is now read-only.
build: disable compiler inlining on z/OS#146
Merged
richardlau merged 1 commit intonodejs:masterfrom Jul 3, 2020
Merged
Conversation
In Node v14 on z/OS, test `test-exception.js` fails due to a compiler issue with inlining. This PR works around it by disabling compiler inlining. I confirmed that, with this change, `npm test` continues to pass in Node v8.17.0 (which uses D190508 compiler version), as well as in Node v12.16.1 (which uses D191122 as in v14). Once the new Wyvern on z compiler is available for use in Node v14, we'll revisit and undo this change if Woz resolves the issue.
Contributor
Author
|
@richardlau can you please review this PR. |
richardlau
approved these changes
Jul 2, 2020
Member
|
(non-z/OS) CI: https://ci.nodejs.org/job/test-nodereport/3/ (✔️) |
richardlau
added a commit
to richardlau/nodereport
that referenced
this pull request
Jul 3, 2020
* build: disable compiler inlining on z/OS (nodejs#146) (Gaby Baghdadi) * readme: add sunset info (nodejs#144) (Gireesh Punathil)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Node v14 on z/OS, test
test-exception.jsfails due to a compiler issue with inlining.This PR works around it by disabling compiler inlining.
I confirmed that, with this change,
npm testcontinues to pass in Node v8.17.0 (which uses D190508 compiler driver), as well as in Node v12.16.1 (which uses D191122 - as in v14).Once the new Wyvern on z compiler is available for use in Node v14, we'll revisit and undo this change if Woz resolves the issue.