Skip to content
This repository was archived by the owner on Feb 1, 2022. It is now read-only.

Conversation

@hybrist
Copy link
Collaborator

@hybrist hybrist commented May 16, 2019

  • Handle switch to file URLs
  • Handle change in sourceText formatting (different new lines, no more CJS wrapper)
  • Handle change in step behavior (there is no more break step at the beginning of the CJS wrapper function)

To clean up the breakpoint matching, I pulled that regex into a dedicated helper in the test harness for launching the CLI.

@hybrist hybrist force-pushed the jkrems/feature/master/fix-test branch from 0fba6a0 to cc4da57 Compare May 30, 2019 09:04
@hybrist hybrist force-pushed the jkrems/feature/master/fix-test branch from cc4da57 to 5b3511e Compare May 30, 2019 09:05
@hybrist
Copy link
Collaborator Author

hybrist commented May 30, 2019

Both nvm exec 10 npm t and nvm exec 12 npm t now pass which should be good enough (and at the very least is a big improvement).

@hybrist hybrist changed the title [WIP] Address regressions due to changes in node Address regressions due to changes in node May 30, 2019
@hybrist
Copy link
Collaborator Author

hybrist commented May 30, 2019

/cc @nodejs/diagnostics

@hybrist
Copy link
Collaborator Author

hybrist commented May 30, 2019

This seems like a good opportunity to a) enable these tests in the node CI runs and/or b) update the status of node-inspect in the diagnostics tool status MD file.

@hybrist hybrist merged commit 68035a6 into master Jun 2, 2019
@hybrist hybrist deleted the jkrems/feature/master/fix-test branch June 2, 2019 20:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants