Issue 297 fixed#945
Closed
roman-yerin wants to merge 1 commit intonodejs:masterfrom
roman-yerin:master
Closed
Conversation
Member
|
I appreciate you took the time to write up a patch, but as a rule, we don't except changes to code in gyp/ because those files come from the upstream gyp project. For easy_xml.py, that rule has been bent in the past but I don't want to make a habit of that. If you can get upstream to accept the patch, I'll be happy to cherry-pick it and do a release. |
Member
|
Seeing how there has been no follow-up, I'll go ahead and close the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.