chore: misc testing fixes #2930
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukekarrys
force-pushed
the
lk/builtin-mocha-reporter
branch
2 times, most recently
from
14e0a4d to
25a2169
Compare
lukekarrys
force-pushed
the
lk/builtin-mocha-reporter
branch
from
25a2169 to
ebcfbd5
Compare
lukekarrys
force-pushed
the
lk/use-es6-classes
branch
from
472c33b to
32a7787
Compare
lukekarrys
force-pushed
the
lk/builtin-mocha-reporter
branch
2 times, most recently
from
e95f094 to
f1a54e8
Compare
lukekarrys
force-pushed
the
lk/use-es6-classes
branch
from
32a7787 to
faa174b
Compare
lukekarrys
force-pushed
the
lk/builtin-mocha-reporter
branch
from
f1a54e8 to
eec377c
Compare
lukekarrys
added a commit
that referenced
this pull request
Oct 28, 2023
* chore: misc test fixes * Sort test runs by os first * Use cross-env for test env var * Try sorting matrix params * Make FAST_TEST the default and rename to FULL_TEST * Separate helper functions to not need to export test obj in files
lukekarrys
added a commit
that referenced
this pull request
Dec 2, 2024
* chore: misc test fixes * Sort test runs by os first * Use cross-env for test env var * Try sorting matrix params * Make FAST_TEST the default and rename to FULL_TEST * Separate helper functions to not need to export test obj in files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
This PR is stacked on #2925
This PR does the following:
npm run lintinto it's own workflow job.FAST_TESTin favor ofFULL_TESTwhich now defaults to off for all test runs in CI except for one permatrix.os. This should speed up tests while still getting the full test suite running on each platform.NODE_GYP_NULL_LOGGERto suppress logs during tests instead of manually settinglog.logger.stream = nullat the top of tests. This environ is then removed from the options passed toexecFileso those tests can collect fromstdout.stdoutis suppressed in tests, the default mocha reports no longer shows extra logs and newlines.testexports for anylib/files. All tested functions are either exported directly from their own files. This involved moving some helper functions from a command file to their own file.