Skip to content

Conversation

@revolter
Copy link
Contributor

Checklist
  • npm install && npm test passes
  • tests are included
  • documentation is changed or added
  • commit message follows commit guidelines
Description of change

@revolter revolter force-pushed the revolter/fix-xcode-casing branch from 7857b03 to 0064d75 Compare August 26, 2023 07:24
@revolter
Copy link
Contributor Author

I rebased my commit (essentially removing your commit and your merge), because I find this kind of git history cleaner, clearer, and easier to understand.

And note that you also (most probably unintentionally) reverted one of my 2 changes while fixing the conflicts during the merge.

@cclauss cclauss merged commit d3615c6 into nodejs:main Aug 26, 2023
@cclauss
Copy link
Contributor

cclauss commented Aug 26, 2023

Nice! Sorry for the mixups!

@revolter revolter deleted the revolter/fix-xcode-casing branch August 26, 2023 13:41
@revolter
Copy link
Contributor Author

No problem, thanks for merging!

lukekarrys pushed a commit that referenced this pull request Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants