test: increase mocha timeout #2887
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The Python lint error is fixed in #2886 |
StefanStojanovic
force-pushed
the
mefi-mocha-timeout-fix
branch
from
47815d0 to
308b309
Compare
StefanStojanovic
force-pushed
the
mefi-mocha-timeout-fix
branch
from
308b309 to
56b4345
Compare
|
Landing this seems to cause errors on our GitHub Actions...
|
lukekarrys
pushed a commit
that referenced
this pull request
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm install && npm testpassesDescription of change
Since migrating from Tap to Mocha it can be observed that sometimes tests will fail on Windows because of the "after all" hook is not executed within 2 seconds. This change increases the default timeout affecting that hook in order to avoid failures due to this hook timing out.