Skip to content

feat: add minimal node-request #2198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

feat: add minimal node-request #2198

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
42d2053
feat: add minimal node-request
imatlopez Aug 23, 2020
ff3ca3a
test: add tests for request-shim
imatlopez Aug 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/install.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,10 @@ const path = require('path')
const crypto = require('crypto')
const log = require('npmlog')
const semver = require('semver')
const request = require('request')
const processRelease = require('./process-release')
const win = process.platform === 'win32'
const getProxyFromURI = require('./proxy')
const Request = require('./request-shim')

function install (fs, gyp, argv, callback) {
var release = processRelease(argv, gyp, process.version, process.release)
Expand Down Expand Up @@ -420,7 +420,7 @@ function download (gyp, env, url) {
}
}

var req = request(requestOpts)
var req = new Request(requestOpts)
req.on('response', function (res) {
log.http(res.statusCode, url)
})
Expand Down
Loading