Code

Bug fix/fix error handling#1925

Code

Closed

dothebart wants to merge 7 commits intonodejs:masternodejs/node-gyp:masterfrom dothebart:bug-fix/fix-error-handlingdothebart/node-gyp:bug-fix/fix-error-handlingCopy head branch name to clipboard

Commits

Commits on Oct 16, 2019

• sys.stderr.write(p_stderr) with python 3 errors out with: TypeError: write() argument must be str, not bytes.

  Show description for 439a8e8
  dothebart

  committed
  439a8e8

  Copy full SHA for 439a8e8

• It seems python 3 doesn't linke None as a parameter here, it will throw: Exception: 'NoneType' object is not subscriptable.

  dothebart

  committed
  25c6a69

  Copy full SHA for 25c6a69

• properly encode strings before handing them over to hashlib.sha

  dothebart

  committed
  19012c8

  Copy full SHA for 19012c8

Commits on Oct 17, 2019

• fix encoding as sugested by @cclaus

  dothebart

  committed
  34dcfad

  Copy full SHA for 34dcfad

• as seen in GYP3 this seems to be the solution here too

  dothebart

  committed
  b695898

  Copy full SHA for b695898

Commits on Oct 30, 2019

• Revert the addition of a blank line

  cclauss

  authored
  15a0ded

  Copy full SHA for 15a0ded

• Revert stderr.decode("utf-8") that was landed in nodejs#1937

  Show description for cea42a4
  cclauss

  authored
  cea42a4

  Copy full SHA for cea42a4