Closed
Conversation
richardlau
approved these changes
Oct 15, 2019
joaocgreis
force-pushed
the
rvagg/update-deps
branch
from
e15150f to
ba0a0b8
Compare
Member
|
Rebased and force-pushed to clear the Windows Travis failure. CI: https://ci.nodejs.org/view/All/job/nodegyp-test-pull-request/167/ |
rvagg
added a commit
that referenced
this pull request
Oct 24, 2019
PR-URL: #1920 Reviewed-By: João Reis <reis@janeasystems.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Member
Author
rvagg
added a commit
that referenced
this pull request
Nov 18, 2019
PR-URL: #1920 Reviewed-By: João Reis <reis@janeasystems.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some overdue dependency updates. I've had a look through the details of most of these updates and I'm not finding anything that would likely impact us. I'm also removing the broad dependency options (
||) which used to be useful when npm was shipping very different versions. I believe they're just shipping version 6 now. Most of the changes here are matching the dependencies that the current npm master is using. I think with these changes,env-pathsmight be the only thing we're pulling in to npm when bundled.There's newer versions of some of these, like tar (this update was prompted by #1918), but npm isn't shipping that yet. I suspect npm is holding back on a lot of updates to maintain older Node compatibility (the README says v6 but .travis.yml says v8).
I believe these changes can be safely backported to v5.x.