Wrong address resolved for headers in an rc release

[MylesBorins]

gyp ERR! configure error
gyp ERR! stack Error: 404 response downloading https://nodejs.org/dist/v4.4.0-rc.1/node-v4.4.0-rc.1-headers.tar.gz

The correct link is https://nodejs.org/download/rc/v4.4.0-rc.1/node-v4.4.0-rc.1-headers.tar.gz

[MylesBorins]

Likely should be fixed in https://github.com/nodejs/node-gyp/blob/818d854a4dbefd0cc6db7498a667730f1e92b4a6/lib/process-release.js as mentioned by @Fishrock123

[rvagg]

I'm not sure how that's going to help, not much has changed there that should impact on v4, are you running this within nvm to get this error?

[MylesBorins]

this is with installing the rc using the .pkg

If you attempt to npm install anything that has natively compiled stuff then everything explodes

[rvagg]

It's a problem with the build, not node-gyp:

$ ./node-v4.4.0-rc.1-linux-x64/bin/node -pe process.release
{ name: 'node',
  lts: 'Argon',
  sourceUrl: 'https://nodejs.org/download/release/v4.4.0-rc.1/node-v4.4.0-rc.1.tar.gz',
  headersUrl: 'https://nodejs.org/download/release/v4.4.0-rc.1/node-v4.4.0-rc.1-headers.tar.gz' }

^ that should be /download/rc/ not /download/release/

It comes from release_urlbase in the build config in Jenkins for releases. It's unfortunate that we don't automate this better but it's kind of tricky in Jenkins (happy for someone to have a go at improving it!).

[MylesBorins]

Ahhh thanks for the heads up... I'll fix the rc's

[MylesBorins]

The rc's have been rebuilt using the appropraite release_urlbase

$ node -pe process.release
{ name: 'node',
  lts: 'Argon',
  sourceUrl: 'https://nodejs.org/download/rc/v4.4.0-rc.1/node-v4.4.0-rc.1.tar.gz',
  headersUrl: 'https://nodejs.org/download/rc/v4.4.0-rc.1/node-v4.4.0-rc.1-headers.tar.gz' }

Still getting the same configure error

gyp ERR! configure error
gyp ERR! stack Error: 404 response downloading https://nodejs.org/dist/v4.4.0-rc.1/node-v4.4.0-rc.1-headers.tar.gz

[rvagg]

works for me

$ curl -sL https://nodejs.org/download/rc/v4.4.0-rc.1/node-v4.4.0-rc.1-linux-x64.tar.xz | tar Jxv
$ ./node-v4.4.0-rc.1-linux-x64/bin/node -pe process.release
{ name: 'node',
  lts: 'Argon',
  sourceUrl: 'https://nodejs.org/download/rc/v4.4.0-rc.1/node-v4.4.0-rc.1.tar.gz',
  headersUrl: 'https://nodejs.org/download/rc/v4.4.0-rc.1/node-v4.4.0-rc.1-headers.tar.gz' }
$ export PATH=$(pwd)/node-v4.4.0-rc.1-linux-x64/bin/:$PATH
$ node -v
v4.4.0-rc.1
$ npm i buffertools
npm http request GET https://registry.npmjs.org/buffertools
npm http 304 https://registry.npmjs.org/buffertools
WARN engine buffertools@2.1.3: wanted: {"node":">=0.3.0"} (current: {"node":"4.4.0-rc.1","npm":"2.14.18"})

> buffertools@2.1.3 install /home/rvagg/node_modules/buffertools
> node-gyp rebuild

gyp http GET https://nodejs.org/download/rc/v4.4.0-rc.1/node-v4.4.0-rc.1-headers.tar.gz
gyp http 200 https://nodejs.org/download/rc/v4.4.0-rc.1/node-v4.4.0-rc.1-headers.tar.gz
gyp http GET https://nodejs.org/download/rc/v4.4.0-rc.1/SHASUMS256.txt
gyp http 200 https://nodejs.org/download/rc/v4.4.0-rc.1/SHASUMS256.txt
make: Entering directory '/home/rvagg/node_modules/buffertools/build'
  CXX(target) Release/obj.target/buffertools/buffertools.o
  SOLINK_MODULE(target) Release/obj.target/buffertools.node
  COPY Release/buffertools.node
make: Leaving directory '/home/rvagg/node_modules/buffertools/build'
buffertools@2.1.3 node_modules/buffertools

[MylesBorins]

On my system isDefaultVersion is resolving to true

This is causing the defaultRelease to be overwritten. semver.parse is evaluating to 4.4.0-rc.1.

[MylesBorins]

Fix submitted
#885