Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename primary branch to main #2495

Closed
mhdawson opened this issue Sep 13, 2021 · 8 comments
Closed

Rename primary branch to main #2495

mhdawson opened this issue Sep 13, 2021 · 8 comments

Comments

@mhdawson
Copy link
Member

We are going through all of the node.js repositories to rename the primary branch to main. Please see nodejs/node#33864 for more context.

The only references I see in the repo to master (other than in links to licence files which should redirect on their own) are:

.github/workflows/release-please.yml
/README.md (buld status branch)

There two would required an update to change master -> main at the same time.

Opening this issue to see what the best way to get the update done. I can rename the branch/update those two files but might better if somebody active in the project does it or we did it together.

@NiceneNerd
Copy link

Gross

@mhdawson
Copy link
Member Author

mhdawson commented Oct 4, 2021

@rvagg do you think there is anything else in addition to the two things I've mentioned that would need to be updated. If not would you be ok with me doing those?

@rvagg
Copy link
Member

rvagg commented Oct 5, 2021

not sure if there's more than that, there's a CI job or two for node-gyp, maybe a default value could be changed in there too

@mhdawson
Copy link
Member Author

mhdawson commented Oct 6, 2021

@rvagg good suggestions
https://ci.nodejs.org/job/nodegyp-test-commit
https://ci.nodejs.org/job/nodegyp-test-commit-arm64/configure

seem to ref master while I don't see it in:

https://ci.nodejs.org/job/nodegyp-test-pull-request/

I could update first two at the same time.

@mhdawson
Copy link
Member Author

We are down to 6 repos that need the rename and this is one of them.

Are there any objections to be renaming and updating the defaults in
https://ci.nodejs.org/job/nodegyp-test-commit
https://ci.nodejs.org/job/nodegyp-test-commit-arm64/configure

@mhdawson
Copy link
Member Author

@nodejs/node-gyp we plan to do the rename for nodejs/node on June 15 at which point this would be the only repo that has not been renamed. Any objections if we rename and do the changes discussed in the previous comments at the same time? If so please let me know before June 15.

@mhdawson
Copy link
Member Author

There were no objections and we've just done the nodejs/node repo so doing here as well.

@mhdawson
Copy link
Member Author

mhdawson commented Jun 15, 2022

  • Branch renamed
  • release-please.yml updated to use main
  • CI jobs in Node.js CI updated to ref main

cclauss added a commit that referenced this issue Jun 22, 2022
cclauss added a commit that referenced this issue Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants