Skip to content

Test broken for node v0.10.x on windows. #1513

Closed
@Rohithzr

Description

@Rohithzr

Issue created for reference only

Node.js v0.10 doesn't have a child_process.execFileSync method: https://nodejs.org/docs/latest-v0.10.x/api/child_process.html

@richardlau It looks like #1203 has inadvertently broken this test on v0.10 (prior to that PR the test used execFile which does exist in v0.10).

see discussions on #1492
fixed by #1492

node - v0.10.x
npm - v2.51.x

Details regarding the fix

test/processExecSync.js adds a function that will emulate the child_process.execSync for legacy node <= 0.10.x

the function runs the given command, saves the [stdout, stderr] and the command status in a temp directory then reads the files to get the output of the said commands.

the function deletes the temp files and folders after the task is complete.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions