This repository was archived by the owner on Jul 31, 2018. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 66
EP-003: stream.Readable#readInto #27
Closed
Closed
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,99 @@ | ||
| Title | stream.Readable#readInto() | | ||
|--------|-----------------------------| | ||
| Author | @indutny | | ||
| Status | DRAFT | | ||
| Date | 2016-06-01 | | ||
|
||
|
||
## 1. Proposal | ||
|
||
It is proposed to add `readInto` method and configuration option to the | ||
`stream.Readable` class. | ||
|
||
```js | ||
const stream = new stream.Readable({ | ||
readInto(buf, offset, length, callback) { | ||
} | ||
}); | ||
|
||
// Asynchronously read data into `buf.slice(offset, offset + length)` | ||
// Invoke continuation with either error (`err`), or original buffer (`buf`), | ||
// original offset (`off`), and number of bytes read (`bytesRead`) | ||
stream.readInto(buf, offset, length, (err, buf, offset, bytesRead) => { | ||
// ... | ||
}); | ||
``` | ||
|
||
## 2. Rationale | ||
|
||
### 2.1 User Perspective | ||
|
||
Currently every `Readable#read()` call will either result in an allocation of | ||
a new `Buffer` instance, or will depend on a previously allocated `Buffer`. | ||
Applications like: | ||
|
||
* "stringifiers" of incoming data | ||
* Parsers that do not store any intermediate values, or re-emit them as a | ||
strings or new `Buffer`s | ||
* _..._ | ||
|
||
...currently incur an extra performance cost and an extra Garbage Collection | ||
load, that is not necessary for their execution. Introduction of `readInto` will | ||
allow skipping this extra-costs through the reuse of the `Buffer`s in | ||
the applications. | ||
|
||
### 2.2 Core Perspective | ||
|
||
TLS, HTTP is now performed mostly within the C++ layer, raising the complexity | ||
and making things less observable for the JavaScript user code. `readInto` may | ||
be one of the instruments that will help us to move TLS and HTTP logic | ||
implementation back into JavaScript. | ||
|
||
## 3. Description of Operation | ||
|
||
### 3.1. Compatibility mode | ||
|
||
Most of the existing streams implementations won't be modified to provide a | ||
`_readInto` implementation. Thus we need to provide a default one that will copy | ||
the data from the `ReadableState#buffer` to the supplied `Buffer` argument. | ||
|
||
On other hand, implementations that have **only** `_readInto` and do not | ||
implement `_read` at all, should still be working. This can be accomplished | ||
by a shim like this: | ||
|
||
```js | ||
// NOTE: Just an example, not a particular implementation that we should stick | ||
// with. | ||
Readable.prototype._read = function _read(size) { | ||
const buf = Buffer.alloc(size); | ||
this._readInto(buf, 0, buf.length, (err, length) => { | ||
if (err) | ||
return this.emit('error', err); | ||
|
||
this.push(buf.slice(0, length)); | ||
}); | ||
}; | ||
``` | ||
|
||
### 3.2. General | ||
|
||
Following scheme applies to a general use case: | ||
|
||
```js | ||
// NOTE: Just an example, not a particular implementation that we should stick | ||
// with. | ||
Readable.prototype.readInto = function readInto(buf, off, len, cb) { | ||
if (this.reading) | ||
return this.queue.push(() => { this.readInto(buf, off, len, cb); }); | ||
|
||
this.reading = true; | ||
this._readInto(buf, off, len, (err, size) => { | ||
this.reading = false; | ||
const item = this.queue.pop(); | ||
if (item) | ||
item(); | ||
|
||
cb(err, buf, off, size); | ||
}); | ||
} | ||
``` |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"may be" is not very confidence building here