Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for nvm #759

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

UlisesGascon
Copy link
Member

No description provided.

@targos
Copy link
Member

targos commented Dec 4, 2023

Not sure what's the point? We want the utils to work on all supported versions, so I think it's good if we have a variety of versions used by collaborators.

@UlisesGascon
Copy link
Member Author

UlisesGascon commented Dec 20, 2023

Not sure what's the point? We want the utils to work on all supported versions, so I think it's good if we have a variety of versions used by collaborators.

I think that is important to use minimum compatible version when developing the library so we prevent to introduce bugs. For example using Node@20 features that are not available in 18.18.0.

The collaborators can use a variety of version defined by the engine https://github.com/nodejs/node-core-utils/blob/main/package.json#L7 independently 👍

@targos
Copy link
Member

targos commented Dec 21, 2023

Ok, I won't block it but I don't use nvm so I'll let someone else review. Please if it lands, don't use feat: (or fix:) in the commit message, as this change doesn't impact users who install the package AFAIK.

@joyeecheung
Copy link
Member

For example using Node@20 features that are not available in 18.18.0.

That should be checked by the CI instead, I believe. The config won't do much for contributors to this repo who don't use nvm, then they won't catch it anyway...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants