Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(git-node): avoid dealing with patch files for landing #486

Merged
merged 2 commits into from
Sep 10, 2020
Merged

chore(git-node): avoid dealing with patch files for landing #486

merged 2 commits into from
Sep 10, 2020

Commits on Sep 7, 2020

  1. chore(git-node): avoid dealing with patch files for landing 

    Working with patch files is, on the one hand, unclean because it
requires manual parsing to figure out e.g. the commit message subjects,
and on the other hand, poses actual problems when dealing with binary
files.

Clean the code up by fetching the original commits themselves and
applying those commits directly.

This also resolves some TODO comments, e.g. we can now check whether
the commits that are to be applied match the ones reported through
the GitHub API.
    @addaleax
    addaleax committed Sep 7, 2020
    Configuration menu
    Copy the full SHA
    3d4537a View commit details
    Browse the repository at this point in the history

  2. fixup! chore(git-node): avoid dealing with patch files for landing

    @addaleax
    addaleax committed Sep 7, 2020
    Configuration menu
    Copy the full SHA
    947ec98 View commit details
    Browse the repository at this point in the history