Skip to content

fix: default date for release #419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2020

Conversation

codebytere
Copy link
Member

Non-confirmation inputs need to have a default date - if no date is provided for the release, default to today's.

cc @targos @joyeecheung

@codebytere codebytere requested review from joyeecheung and targos May 18, 2020 01:43
@codecov
Copy link

codecov bot commented May 18, 2020

Codecov Report

Merging #419 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #419   +/-   ##
=======================================
  Coverage   76.34%   76.34%           
=======================================
  Files          21       21           
  Lines        1484     1484           
=======================================
  Hits         1133     1133           
  Misses        351      351           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfe7adf...0b9bf40. Read the comment docs.

@codebytere codebytere merged commit ecc7f0c into nodejs:master May 19, 2020
@codebytere codebytere deleted the fix-missing-date-default branch May 19, 2020 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants