lib: don't print dash for users without names#236
Merged
joyeecheung merged 1 commit intonodejs:masterfrom Apr 17, 2018
Merged
Conversation
when logging team data we currently include a dash between the profile name / link and the account name. If the account name is blank, we still include the dash. This patch changes the behavior to remove the dash in cases that the name is blank.
Codecov Report
@@ Coverage Diff @@
## master #236 +/- ##
==========================================
+ Coverage 88.54% 88.55% +0.01%
==========================================
Files 19 19
Lines 707 708 +1
==========================================
+ Hits 626 627 +1
Misses 81 81
Continue to review full report at Codecov.
|
joyeecheung
approved these changes
Apr 17, 2018
Contributor
Author
|
🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when logging team data we currently include a dash between
the profile name / link and the account name. If the account
name is blank, we still include the dash. This patch changes
the behavior to remove the dash in cases that the name
is blank.