Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: accept extra spaces in the collaborators list #182

Merged
merged 2 commits into from
Feb 17, 2018
Merged

lib: accept extra spaces in the collaborators list #182

merged 2 commits into from
Feb 17, 2018

Conversation

mmarchini
Copy link
Contributor

get-metadata will skip collaborators from the list without warning if there are extra spaces. For example:

* [mmarchini](https://github.com/mmarchini) -
**Matheus Marchini**  <matheus@sthima.com>
                     ^
                     Extra space

Ref: nodejs/node#18822

@codecov
Copy link

codecov bot commented Feb 16, 2018 •
edited
Loading

Codecov Report

Merging #182 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #182      +/-   ##
==========================================
+ Coverage   93.69%   93.71%   +0.01%     
==========================================
  Files          18       18              
  Lines         666      668       +2     
==========================================
+ Hits          624      626       +2     
  Misses         42       42
Impacted Files Coverage Δ
lib/collaborators.js 100% <100%> (ø) ⬆️
lib/pr_summary.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75f2b21...1f70458. Read the comment docs.

joyeecheung
joyeecheung approved these changes Feb 16, 2018
View reviewed changes
Copy link
Member

@joyeecheung joyeecheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching that!

priyank-p
priyank-p approved these changes Feb 16, 2018
View reviewed changes
Copy link
Contributor

@priyank-p priyank-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to add a quick tests for it in collaborators.test.js

@priyank-p priyank-p self-assigned this Feb 17, 2018
@priyank-p priyank-p merged commit a15715a into nodejs:master Feb 17, 2018
@priyank-p
Copy link
Contributor

Merged after adding a quick little test, thanks @mmarchini.

@snyk-bot snyk-bot mentioned this pull request Sep 13, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@priyank-p priyank-p priyank-p approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@tniessen tniessen tniessen approved these changes

Assignees

@priyank-p priyank-p

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mmarchini @priyank-p @tniessen @joyeecheung