Skip to content

Handle #issuecomment-371266836 like strings in PR link #206

Closed
@gibfahn

Description

@gibfahn

Often when you're going through your notifications, you end up with something on the end of the pull request URL, for example:

https://github.com/nodejs/node/pull/19201#issuecomment-371266836
https://github.com/nodejs/node/pull/19201#event-1509291051
https://github.com/nodejs/node/pull/19201/files
https://github.com/nodejs/node/pull/19201#pullrequestreview-102067476

If you run git node metadata https://github.com/nodejs/node/pull/19201#issuecomment-371266836 it just shows the help text.

It should be easy to adjust the regex to handle anything of the form

https://(?:www.)github.com/(\w\+)/(\w\+)/pull/([0-9]+).*

and just capture the three things you need (in ()).

Also https://www.github.com/nodejs/node/pull/19201 doesn't currently work.

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementThings that enhances functionality, provided by node-core-utilsfeature requestNew features for node-core-utils

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions