Skip to content
This repository was archived by the owner on Oct 7, 2020. It is now read-only.
This repository was archived by the owner on Oct 7, 2020. It is now read-only.

[Converge] repl: Private Buffer object in lib/* files #21

Description

@jasnell

See: nodejs/node-v0.x-archive@523929c
/cc @trevnorris

The original commit log says, "Fixes usage of global object 'Buffer' in lib/* files by ensuring that each file does an explicit require('buffer').Buffer. Previously, when running a repl, due to usage of global 'Buffer', any redefinition of Buffer would cause a crash eg var Buffer = {}."

Activity

  1. Fishrock123 commented on May 21, 2015

    @Fishrock123
    Contributor

    This should be ported to io.js.

  2. Fishrock123 commented on Jun 1, 2015

    @Fishrock123
    Contributor

    The plan is to add linting alongside doing an updated version of this. progress here: nodejs/node#1794

  3. silverwind commented on Jun 11, 2015

    @silverwind
    Contributor

    Landed a ported version in nodejs/node@b5b8ff1, notable difference is that the workaround for the race condition wasn't necessary any more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions