This repository has been archived by the owner on Oct 15, 2020. It is now read-only.
Fixing up the v8.x branch to make it linear #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I thought that the release tags were supposed to be dead-end offshoots? If not, this looks fine to me. |
MSLaguana
approved these changes
Nov 27, 2017
|
Node keeps the history linear, so we should too. The update-changelog script also looks for tags in the current branch, so it won't find it unless the history is linear. |
PR-URL: nodejs#434 Reviewed-By: Jimmy Thomson <jithomso@microsoft.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing up the branch to place the v8.6.0 tag in the history. This was a fast forward. I then reset the release flag on the branch.
Checklist
Affected core subsystem(s)
src