Skip to content
This repository has been archived by the owner on Oct 15, 2020. It is now read-only.

Commit

Permalink
src,test: enable bigint tests on v8
Browse files Browse the repository at this point in the history
* Use eval to enable tests to run on v8 and chakracore
* Clean up status files
* Fix some lint issues

PR-URL: #593
Reviewed-By: Jimmy Thomson <jithomso@microsoft.com>
Reviewed-By: Irina Yatsenko <irinayat@microsoft.com>
Reviewed-By: Seth Brenith <sethb@microsoft.com>
  • Loading branch information
kfarnung committed Sep 11, 2018
1 parent a9097d6 commit 0d67655
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
2 changes: 0 additions & 2 deletions test/parallel/parallel.status
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,6 @@ test-trace-events-process-exit : SKIP
test-trace-events-v8 : SKIP
test-trace-events-vm : SKIP
test-trace-events-worker-metadata : SKIP
test-trace-event-promises : SKIP
test-tracing-no-crash : SKIP

# These tests are disabled for chakra engine because they depend
Expand Down Expand Up @@ -150,7 +149,6 @@ test-vm-module-link : SKIP
test-vm-module-reevaluate : SKIP

# This test requires support for bigints
test-util-inspect-bigint : SKIP
test-fs-stat-bigint : SKIP
test-fs-watchfile-bigint : SKIP
test-process-hrtime-bigint : SKIP
Expand Down
6 changes: 6 additions & 0 deletions test/parallel/test-assert-deep.js
Original file line number Diff line number Diff line change
Expand Up @@ -363,6 +363,9 @@ assertDeepAndStrictEqual(
new Map([[null, 3]]),
new Map([[null, 3]])
);

if (!common.isChakraEngine) {
eval(`
assertOnlyDeepEqual(
new Map([[undefined, null], ['+000', 2n]]),
new Map([[null, undefined], [false, '2']]),
Expand All @@ -372,6 +375,9 @@ assertOnlyDeepEqual(
new Set([null, '', 1n, 5, 2n, false]),
new Set([undefined, 0, 5n, true, '2', '-000'])
);
`);
}

assertNotDeepOrStrict(
new Set(['']),
new Set(['0'])
Expand Down

0 comments on commit 0d67655

Please sign in to comment.