Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: print more instructions on clang-format check failed #846

Merged
merged 1 commit into from
Dec 3, 2020
Merged

tools: print more instructions on clang-format check failed #846

merged 1 commit into from
Dec 3, 2020

Conversation

legendecas
Copy link
Member

mhdawson
mhdawson approved these changes Dec 3, 2020
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this will help

@mhdawson mhdawson merged commit d5e3721 into nodejs:master Dec 3, 2020
@legendecas legendecas deleted the lint-help branch December 4, 2020 03:57
kevindavies8 added a commit to kevindavies8/node-addon-api-Develop that referenced this pull request Aug 24, 2022
@kevindavies8
tools: print more instructions on clang-format check failed (#846)
63933f0 
PR-URL: nodejs/node-addon-api#846
Reviewed-By: Michael Dawson <midawson@redhat.com>
Marlyfleitas added a commit to Marlyfleitas/node-api-addon-Development that referenced this pull request Aug 26, 2022
@Marlyfleitas
tools: print more instructions on clang-format check failed (#846)
ddaad88 
PR-URL: nodejs/node-addon-api#846
Reviewed-By: Michael Dawson <midawson@redhat.com>
wroy7860 added a commit to wroy7860/addon-api-benchmark-node that referenced this pull request Sep 19, 2022
@wroy7860
tools: print more instructions on clang-format check failed (#846)
2079785 
PR-URL: nodejs/node-addon-api#846
Reviewed-By: Michael Dawson <midawson@redhat.com>
johnfrench3 pushed a commit to johnfrench3/node-addon-api-git that referenced this pull request Aug 11, 2023
tools: print more instructions on clang-format check failed (#846)
69b8720 
PR-URL: nodejs/node-addon-api#846
Reviewed-By: Michael Dawson <midawson@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@legendecas @mhdawson