Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix up delays for array buffer test #737

Closed
wants to merge 1 commit into from

Conversation

mhdawson
Copy link
Member

Refs: #735

Signed-off-by: Michael Dawson michael_dawson@ca.ibm.com

Refs: nodejs#735

Signed-off-by: Michael Dawson <michael_dawson@ca.ibm.com>
@mhdawson
Copy link
Member Author

@addaleax thanks for the fast review. Going to land this so we can get the node-addon-api CI back to green. I tested manually and all tests pass on versions 15, 14,13, 12 and 10

mhdawson added a commit that referenced this pull request May 25, 2020
Signed-off-by: Michael Dawson <michael_dawson@ca.ibm.com>

PR-URL: #737
Refs: #735
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@mhdawson
Copy link
Member Author

Landed as: beccf21

@mhdawson
Copy link
Member Author

@mhdawson
Copy link
Member Author

CI was green, closing.

@mhdawson mhdawson closed this May 25, 2020
kevindavies8 added a commit to kevindavies8/node-addon-api-Develop that referenced this pull request Aug 24, 2022
Signed-off-by: Michael Dawson <michael_dawson@ca.ibm.com>

PR-URL: nodejs/node-addon-api#737
Refs: nodejs/node-addon-api#735
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Marlyfleitas added a commit to Marlyfleitas/node-api-addon-Development that referenced this pull request Aug 26, 2022
Signed-off-by: Michael Dawson <michael_dawson@ca.ibm.com>

PR-URL: nodejs/node-addon-api#737
Refs: nodejs/node-addon-api#735
Reviewed-By: Anna Henningsen <anna@addaleax.net>
wroy7860 added a commit to wroy7860/addon-api-benchmark-node that referenced this pull request Sep 19, 2022
Signed-off-by: Michael Dawson <michael_dawson@ca.ibm.com>

PR-URL: nodejs/node-addon-api#737
Refs: nodejs/node-addon-api#735
Reviewed-By: Anna Henningsen <anna@addaleax.net>
johnfrench3 pushed a commit to johnfrench3/node-addon-api-git that referenced this pull request Aug 11, 2023
Signed-off-by: Michael Dawson <michael_dawson@ca.ibm.com>

PR-URL: nodejs/node-addon-api#737
Refs: nodejs/node-addon-api#735
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants