-
Notifications
You must be signed in to change notification settings - Fork 459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some fix on documentation and added new section dedicated to prebuild tools #353
Conversation
…ols. Fix typo Fixed broken links
doc/prebuild_tools.md
Outdated
The end-user will need to compile the add-on when they will do an `npm install` | ||
and in some cases this could create problems. To avoid the compilation process it's | ||
possible to ditribute the native add-on in pre-built form for different platform | ||
and architecture. The prebuild tools help to create and distrubute the pre-built |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
architecture -> architectures
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a few nits
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
- Some fix on bigint and dataview. - Add section dedicated to prebuild tools. PR-URL: #353 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Landed as 51ffe45 |
- Some fix on bigint and dataview. - Add section dedicated to prebuild tools. PR-URL: nodejs/node-addon-api#353 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
- Some fix on bigint and dataview. - Add section dedicated to prebuild tools. PR-URL: nodejs/node-addon-api#353 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
- Some fix on bigint and dataview. - Add section dedicated to prebuild tools. PR-URL: nodejs/node-addon-api#353 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
- Some fix on bigint and dataview. - Add section dedicated to prebuild tools. PR-URL: nodejs/node-addon-api#353 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
In this PR I fixed some inconsistencies over the
Napi::BigInt
andNapi::DataView
documentation, then I added a new section called pre build tools where I tried to briefly explain what is a pre build tool and why it's important use one of them.Please review.