Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CI configs #257

Closed
wants to merge 2 commits into from
Closed

Update CI configs #257

wants to merge 2 commits into from

Conversation

kfarnung
Copy link
Contributor

@kfarnung kfarnung commented May 3, 2018

  • Fix missing pip in macOS builds
  • Add new builds to the matrix

@kfarnung
Copy link
Contributor Author

kfarnung commented May 3, 2018

https://travis-ci.org/kfarnung/node-addon-api

The matrix is pretty large now, I'm open to suggestions for reductions.

@mhdawson
Copy link
Member

mhdawson commented May 3, 2018

We actually run the tests across platforms here: https://ci.nodejs.org/view/x%20-%20Abi%20stable%20module%20API/job/node-test-node-addon-api/

Right now we run master nightly, and the others when we create releases. We should at least document that there are 2 places to look, if not try to cover them both in the community CI.

@kfarnung
Copy link
Contributor Author

kfarnung commented May 3, 2018

I wasn't aware of that, I just had Travis-CI setup for my fork and it was failing for a while. Does the that CI run include older versions of node as well?

@kfarnung
Copy link
Contributor Author

kfarnung commented May 7, 2018

I think it's either worth landing these changes or deleting the files. Do we have any node-addon-api CI coverage for ChakraCore in the official CI?

@mhdawson
Copy link
Member

mhdawson commented May 7, 2018

If you mean in the official CI for the n-api tests, no. I assume it would be a clone of the existing job, with possibly a smaller set of supported platforms, and then have it pull the chakra published versions. It does depend on binaries being already built/available.

@kfarnung
Copy link
Contributor Author

kfarnung commented May 7, 2018

We do have official builds: https://nodejs.org/download/chakracore-release/
And nightly builds: https://nodejs.org/download/chakracore-nightly/

For platforms we currently support Windows (x86 and x64), macOS (x64), and Linux (x64).

mhdawson
mhdawson approved these changes Jun 14, 2018
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will land and we can continue to discuss how to improve testing.

mhdawson pushed a commit that referenced this pull request Jun 14, 2018
@kfarnung @mhdawson
fix test files
12b2cde 
Fix missing `pip` in macOS builds
Add new builds to the matrix

PR-URL: #257
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@mhdawson
Copy link
Member

Landed as 12b2cde

@mhdawson mhdawson closed this Jun 14, 2018
kevindavies8 added a commit to kevindavies8/node-addon-api-Develop that referenced this pull request Aug 24, 2022
@kevindavies8
fix test files
855a274 
Fix missing `pip` in macOS builds
Add new builds to the matrix

PR-URL: nodejs/node-addon-api#257
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Marlyfleitas added a commit to Marlyfleitas/node-api-addon-Development that referenced this pull request Aug 26, 2022
@Marlyfleitas
fix test files
a251c0c 
Fix missing `pip` in macOS builds
Add new builds to the matrix

PR-URL: nodejs/node-addon-api#257
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
wroy7860 added a commit to wroy7860/addon-api-benchmark-node that referenced this pull request Sep 19, 2022
@wroy7860
fix test files
bebdbed 
Fix missing `pip` in macOS builds
Add new builds to the matrix

PR-URL: nodejs/node-addon-api#257
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
johnfrench3 pushed a commit to johnfrench3/node-addon-api-git that referenced this pull request Aug 11, 2023
fix test files
f91c185 
Fix missing `pip` in macOS builds
Add new builds to the matrix

PR-URL: nodejs/node-addon-api#257
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kfarnung @mhdawson