Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

n-api: throw RangeError in napi_create_dataview() with invalid range #214

Closed
wants to merge 1 commit into from
Closed

n-api: throw RangeError in napi_create_dataview() with invalid range #214

wants to merge 1 commit into from

Commits on Jan 14, 2018

  1. n-api: throw RangeError in napi_create_dataview() with invalid range 

    The API is required that `byte_length + byte_offset` is less than or
equal to the size in bytes of the array passed in. If not, a RangeError
exception is raised[1].

This is a partial cherry-pick from upstream[2].

[1] https://nodejs.org/api/n-api.html#n_api_napi_create_dataview
[2] nodejs/node@2e329e9
    @romandev
    romandev committed Jan 14, 2018
    Configuration menu
    Copy the full SHA
    1084024 View commit details
    Browse the repository at this point in the history