Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1688 +/- ##
=======================================
Coverage 63.48% 63.48%
=======================================
Files 3 3
Lines 2046 2046
Branches 728 728
=======================================
Hits 1299 1299
Misses 162 162
Partials 585 585 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
legendecas
reviewed
Oct 29, 2025
Contributor
Author
Non-experimental Jenkins CI builds
|
legendecas
reviewed
Nov 28, 2025
Member
There was a problem hiding this comment.
Would you mind adding a test case in https://github.com/nodejs/node-addon-api/blob/main/test/value_type_cast.cc as well? Or we can add it as a follow-up.
legendecas
approved these changes
Nov 28, 2025
Contributor
Author
|
@legendecas, I added the value_type_cast test! PTAL |
legendecas
approved these changes
Dec 3, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Napi::SharedArrayBufferValue::IsSharedArrayBuffer()