-
-
Notifications
You must be signed in to change notification settings - Fork 474
feat: add sugar method for PropertyLValue (#1651) #1655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@neko-para thanks for the PR, could you add a test as well? |
Actually i'm not sure where should i add the tests. Maybe i shall add an extra entry? |
Tests added. |
@neko-para just to confirm its not possible to use the existing operator:
instead of adding the AsValue method ? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1655 +/- ##
==========================================
+ Coverage 65.76% 65.79% +0.03%
==========================================
Files 3 3
Lines 2144 2146 +2
Branches 715 715
==========================================
+ Hits 1410 1412 +2
Misses 162 162
Partials 572 572 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The cast operator should always work. Adding the method is generally only for convenience, as explicit calling cast operator is not as intuitive as calling method. |
No description provided.