Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: amend outdated doc about multiple environments #1586

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

legendecas
Copy link
Member

@legendecas legendecas commented Oct 4, 2024

Since the first stable version of node-api, multiple environments are supported.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.42%. Comparing base (d8523a7) to head (5f9ea99).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1586   +/-   ##
=======================================
  Coverage   64.42%   64.42%           
=======================================
  Files           3        3           
  Lines        2010     2010           
  Branches      699      699           
=======================================
  Hits         1295     1295           
  Misses        147      147           
  Partials      568      568           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@legendecas legendecas merged commit f12f2f5 into nodejs:main Oct 7, 2024
48 checks passed
@legendecas legendecas deleted the doc-env branch October 7, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants