Skip to content

Add internals for async context and NewTarget#154

Closed
gabrielschulhof wants to merge 2 commits intonodejs:masterfrom
gabrielschulhof:fix-older-node-versions
Closed

Add internals for async context and NewTarget#154
gabrielschulhof wants to merge 2 commits intonodejs:masterfrom
gabrielschulhof:fix-older-node-versions

Conversation

@gabrielschulhof
Copy link
Contributor

@gabrielschulhof gabrielschulhof commented Oct 9, 2017

@gabrielschulhof
Copy link
Contributor Author

gabrielschulhof commented Oct 9, 2017

@jasongin between versions 8.0.0 and below 8.6.0 EmitAsyncInit() and EmitAsyncDestroy() are available, albeit with double async_uid rather than the structure that's used after 8.6.0. Is it worth the effort to conditionally flesh out our src/node_internals.cc implementation of EmitAsyncInit() and EmitAsyncDestroy() with calls to the methods available in node? If so, can we hand-hold values for the async_uid parameter by storing them inside our definition of the async_id structure?

@jasongin
Copy link
Member

jasongin commented Oct 9, 2017

I think it's probably not worth it to support an older variant of an API that was (and still is) experimental.

mhdawson
mhdawson approved these changes Oct 11, 2017
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mhdawson pushed a commit that referenced this pull request Oct 11, 2017
@mhdawson
Add internals for async context and NewTarget
1a6d76e 
PR-URL: #154
Reviewed-By: Jason Ginchereau <jasongin@microsoft.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@mhdawson
Copy link
Member

mhdawson commented Oct 11, 2017

Landed as 1a6d76e

@mhdawson mhdawson closed this Oct 11, 2017
kevindavies8 added a commit to kevindavies8/node-addon-api-Develop that referenced this pull request Aug 24, 2022
@kevindavies8
Add internals for async context and NewTarget
3b01c58 
PR-URL: nodejs/node-addon-api#154
Reviewed-By: Jason Ginchereau <jasongin@microsoft.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Marlyfleitas added a commit to Marlyfleitas/node-api-addon-Development that referenced this pull request Aug 26, 2022
@Marlyfleitas
Add internals for async context and NewTarget
a6f7f97 
PR-URL: nodejs/node-addon-api#154
Reviewed-By: Jason Ginchereau <jasongin@microsoft.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
wroy7860 added a commit to wroy7860/addon-api-benchmark-node that referenced this pull request Sep 19, 2022
@wroy7860
Add internals for async context and NewTarget
153d868 
PR-URL: nodejs/node-addon-api#154
Reviewed-By: Jason Ginchereau <jasongin@microsoft.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
johnfrench3 pushed a commit to johnfrench3/node-addon-api-git that referenced this pull request Aug 11, 2023
Add internals for async context and NewTarget
89ddf0e 
PR-URL: nodejs/node-addon-api#154
Reviewed-By: Jason Ginchereau <jasongin@microsoft.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mhdawson mhdawson mhdawson approved these changes

+1 more reviewer

@jasongin jasongin jasongin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gabrielschulhof @jasongin @mhdawson