Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: restore ability to run under NAPI_EXPERIMENTAL #1409

Commits on May 29, 2024

  1. src: restore ability to run under NAPI_EXPERIMENTAL

    Since we made the default for Node.js core finalizers synchronous for
    users running with `NAPI_EXPERIMENTAL` and introduced
    `env->CheckGCAccess()` in Node.js core, we must now defer all
    finalizers in node-addon-api, because our users likely make non-gc-safe
    Node-API calls from existing finalizers. To that end,
      * Use the NAPI_VERSION environment variable to detect whether
        `NAPI_EXPERIMENTAL` should be on, and add it to the defines if
        `NAPI_VERSION` is set to `NAPI_VERSION_EXPERIMENTAL`, i.e.
        2147483647.
      * When building with `NAPI_EXPERIMENTAL`,
        * render all finalizers asynchronous, and
        * expect `napi_cannot_run_js` instead of `napi_exception_pending`.
    gabrielschulhof committed May 29, 2024
    Configuration menu
    Copy the full SHA
    84b5f8e View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2024

  1. Configuration menu
    Copy the full SHA
    1a11e3a View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2024

  1. Configuration menu
    Copy the full SHA
    2bfdaac View commit details
    Browse the repository at this point in the history