Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Adding test for ThreadSafeFunction::Ref #1222

Closed
wants to merge 1 commit into from

Conversation

JckXia
Copy link
Member

@JckXia JckXia commented Oct 18, 2022

A mirror of pr #1196, but for ThreadSafeFunction class

@JckXia JckXia changed the title test: Adding ref for ThreadSafeFunction::Ref test: Adding test for ThreadSafeFunction::Ref Oct 18, 2022
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mhdawson pushed a commit that referenced this pull request Oct 26, 2022
PR-URL: #1222
Reviewed-By: Michael Dawson <midawson@redhat.com>
@mhdawson
Copy link
Member

Landed as e408804

@mhdawson mhdawson closed this Oct 26, 2022
johnfrench3 pushed a commit to johnfrench3/node-addon-api-git that referenced this pull request Aug 11, 2023
PR-URL: nodejs/node-addon-api#1222
Reviewed-By: Michael Dawson <midawson@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants