test: Add TypedArray ElementSize, ByteLength and ByteOffset tests #1179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dantehemerson
commented
May 17, 2022
Comment on lines
+9
to
+17
| ['int8', Int8Array, 1], | ||
| ['uint8', Uint8Array, 1], | ||
| ['uint8_clamped', Uint8ClampedArray, 1], | ||
| ['int16', Int16Array, 2], | ||
| ['uint16', Uint16Array, 2], | ||
| ['int32', Int32Array, 4], | ||
| ['uint32', Uint32Array, 4], | ||
| ['float32', Float32Array, 4], | ||
| ['float64', Float64Array, 8] |
There was a problem hiding this comment.
dantehemerson
changed the title
dantehemerson
force-pushed
the
feature/typedarray-element-size
branch
from
8cbc9fa
to
f0b9256
Compare
dantehemerson
force-pushed
the
feature/typedarray-element-size
branch
from
e5cc439
to
bdc4c59
Compare
dantehemerson
changed the title
dantehemerson
changed the title
mhdawson
pushed a commit
that referenced
this pull request
May 27, 2022
Add tests for TypedArray#ElementSize Add tests for TypedArray#BufferLength Add tests for TypedArray#ByteOffset PR-URL: #1179 Reviewed-By: Kevin Eady <kevin.c.eady@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com
|
Landed as 63d3c30 @dantehemerson thanks. |
kevindavies8
added a commit
to kevindavies8/node-addon-api-Develop
that referenced
this pull request
Aug 24, 2022
Add tests for TypedArray#ElementSize Add tests for TypedArray#BufferLength Add tests for TypedArray#ByteOffset PR-URL: nodejs/node-addon-api#1179 Reviewed-By: Kevin Eady <kevin.c.eady@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com
Marlyfleitas
added a commit
to Marlyfleitas/node-api-addon-Development
that referenced
this pull request
Aug 26, 2022
Add tests for TypedArray#ElementSize Add tests for TypedArray#BufferLength Add tests for TypedArray#ByteOffset PR-URL: nodejs/node-addon-api#1179 Reviewed-By: Kevin Eady <kevin.c.eady@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com
wroy7860
added a commit
to wroy7860/addon-api-benchmark-node
that referenced
this pull request
Sep 19, 2022
Add tests for TypedArray#ElementSize Add tests for TypedArray#BufferLength Add tests for TypedArray#ByteOffset PR-URL: nodejs/node-addon-api#1179 Reviewed-By: Kevin Eady <kevin.c.eady@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com
johnfrench3
pushed a commit
to johnfrench3/node-addon-api-git
that referenced
this pull request
Aug 11, 2023
Add tests for TypedArray#ElementSize Add tests for TypedArray#BufferLength Add tests for TypedArray#ByteOffset PR-URL: nodejs/node-addon-api#1179 Reviewed-By: Kevin Eady <kevin.c.eady@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mentioned on #964
Add tests for the TypeadArray methods: