test: Check for tsfn in condition_variable wait #1168
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Run on 12.x where it seems to fail the most - https://ci.nodejs.org/view/x%20-%20Abi%20stable%20module%20API/job/node-test-node-addon-api-new/5783/ |
|
The CI runs that I started looked good. I'll go ahead and land as it should help get the ci green :). @KevinEady thanks for working on this. |
|
Landed in 24455f8 |
|
Whoo-hoo a full green CI run across Node.js runs after landing this - https://ci.nodejs.org/view/x%20-%20Abi%20stable%20module%20API/job/node-test-node-addon-api-LTS%20versions/1481/ |
kevindavies8
added a commit
to kevindavies8/node-addon-api-Develop
that referenced
this pull request
Aug 24, 2022
Fixes: #1150 PR-URL: nodejs/node-addon-api#1168 Reviewed-By: Michael Dawson <midawson@redhat.com
Marlyfleitas
added a commit
to Marlyfleitas/node-api-addon-Development
that referenced
this pull request
Aug 26, 2022
Fixes: #1150 PR-URL: nodejs/node-addon-api#1168 Reviewed-By: Michael Dawson <midawson@redhat.com
wroy7860
added a commit
to wroy7860/addon-api-benchmark-node
that referenced
this pull request
Sep 19, 2022
Fixes: #1150 PR-URL: nodejs/node-addon-api#1168 Reviewed-By: Michael Dawson <midawson@redhat.com
johnfrench3
pushed a commit
to johnfrench3/node-addon-api-git
that referenced
this pull request
Aug 11, 2023
Fixes: #1150 PR-URL: nodejs/node-addon-api#1168 Reviewed-By: Michael Dawson <midawson@redhat.com
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under certain conditions, the main thread may set the TSFN and notify the condition variable prior to the thread waiting on it, causing an indefinite hang. This PR fixes the hang by skipping the wait if the TSFN has been set.
Fixes: #1150