src: fix regression introduced by #874 #1159
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: nodejs#1158 Revert part of nodejs#874 to avoid breaking existing code. Signed-off-by: Michael Dawson <mdawson@devrus.com>
|
@ShenHongFei FYI |
|
@nodejs/node-api it would be good to get this landed before the next release. Could somebody take a look/approve? |
KevinEady
approved these changes
Apr 12, 2022
mhdawson
added a commit
that referenced
this pull request
Apr 13, 2022
Fixes: #1158 Revert part of #874 to avoid breaking existing code. PR-URL: #1159 (review) Reviewed-By: Kevin Eady <kevin.c.eady@gmail.com> Signed-off-by: Michael Dawson <mdawson@devrus.com>
|
Landed in 40ed7ce |
kevindavies8
added a commit
to kevindavies8/node-addon-api-Develop
that referenced
this pull request
Aug 24, 2022
Fixes: nodejs/node-addon-api#1158 Revert part of nodejs/node-addon-api#874 to avoid breaking existing code. PR-URL: nodejs/node-addon-api#1159 (review) Reviewed-By: Kevin Eady <kevin.c.eady@gmail.com> Signed-off-by: Michael Dawson <mdawson@devrus.com>
Marlyfleitas
added a commit
to Marlyfleitas/node-api-addon-Development
that referenced
this pull request
Aug 26, 2022
Fixes: nodejs/node-addon-api#1158 Revert part of nodejs/node-addon-api#874 to avoid breaking existing code. PR-URL: nodejs/node-addon-api#1159 (review) Reviewed-By: Kevin Eady <kevin.c.eady@gmail.com> Signed-off-by: Michael Dawson <mdawson@devrus.com>
wroy7860
added a commit
to wroy7860/addon-api-benchmark-node
that referenced
this pull request
Sep 19, 2022
Fixes: nodejs/node-addon-api#1158 Revert part of nodejs/node-addon-api#874 to avoid breaking existing code. PR-URL: nodejs/node-addon-api#1159 (review) Reviewed-By: Kevin Eady <kevin.c.eady@gmail.com> Signed-off-by: Michael Dawson <mdawson@devrus.com>
johnfrench3
pushed a commit
to johnfrench3/node-addon-api-git
that referenced
this pull request
Aug 11, 2023
Fixes: nodejs/node-addon-api#1158 Revert part of nodejs/node-addon-api#874 to avoid breaking existing code. PR-URL: nodejs/node-addon-api#1159 (review) Reviewed-By: Kevin Eady <kevin.c.eady@gmail.com> Signed-off-by: Michael Dawson <mdawson@devrus.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1158
Revert part of #874
to avoid breaking existing code.
Signed-off-by: Michael Dawson mdawson@devrus.com