Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: document object iterators #1090

Merged
merged 1 commit into from
Oct 25, 2021

Conversation

RaisinTen
Copy link
Contributor

Signed-off-by: Darshan Sen darshan.sen@postman.com

@RaisinTen
Copy link
Contributor Author

cc @NickNaso I've followed the suggestions you've left in #930 (review) :)

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson
Copy link
Member

@RaisinTen thanks for creating this follow up PR.

Copy link
Member

@NickNaso NickNaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done, just few notes.

doc/object.md Outdated Show resolved Hide resolved
doc/object.md Outdated Show resolved Hide resolved
doc/object.md Outdated Show resolved Hide resolved
doc/object.md Outdated Show resolved Hide resolved
Signed-off-by: Darshan Sen <darshan.sen@postman.com>
@RaisinTen RaisinTen force-pushed the doc/document-object-iterators branch from a4d851c to dfe39ee Compare October 15, 2021 15:12
@RaisinTen
Copy link
Contributor Author

@NickNaso thanks, updated accordingly :)

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson mhdawson merged commit 0dfa89f into nodejs:main Oct 25, 2021
@RaisinTen RaisinTen deleted the doc/document-object-iterators branch October 26, 2021 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants