doc: fix documentation about how to enable C++ exception #1059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepakrkris
pushed a commit
to deepakrkris/node-addon-api
that referenced
this pull request
Sep 23, 2021
* doc: fixed doc about how to enable C++ exceptions. PR-URL: nodejs#1059 Reviewed-By: Michael Dawson <midawson@redhat.com>
deepakrkris
pushed a commit
to deepakrkris/node-addon-api
that referenced
this pull request
Oct 15, 2021
* doc: fixed doc about how to enable C++ exceptions. PR-URL: nodejs#1059 Reviewed-By: Michael Dawson <midawson@redhat.com>
kevindavies8
added a commit
to kevindavies8/node-addon-api-Develop
that referenced
this pull request
Aug 24, 2022
* doc: fixed doc about how to enable C++ exceptions. PR-URL: nodejs/node-addon-api#1059 Reviewed-By: Michael Dawson <midawson@redhat.com>
Marlyfleitas
added a commit
to Marlyfleitas/node-api-addon-Development
that referenced
this pull request
Aug 26, 2022
* doc: fixed doc about how to enable C++ exceptions. PR-URL: nodejs/node-addon-api#1059 Reviewed-By: Michael Dawson <midawson@redhat.com>
wroy7860
added a commit
to wroy7860/addon-api-benchmark-node
that referenced
this pull request
Sep 19, 2022
* doc: fixed doc about how to enable C++ exceptions. PR-URL: nodejs/node-addon-api#1059 Reviewed-By: Michael Dawson <midawson@redhat.com>
johnfrench3
pushed a commit
to johnfrench3/node-addon-api-git
that referenced
this pull request
Aug 11, 2023
* doc: fixed doc about how to enable C++ exceptions. PR-URL: nodejs/node-addon-api#1059 Reviewed-By: Michael Dawson <midawson@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the documentation about how to enbale C++ exception. The problem was identified the first time in this issue: #85. In Windows system is not enough add the following configuration on
binding.gyp:but it's necessary override the defined
_HAS_EXCEPTIONSmacro and set it to 1.In the
common.gypi(see: https://github.com/nodejs/node/blob/master/common.gypi#L273) the_HAS_EXCEPTIONShas been set to 0 to make sure the STL doesn't try to use exceptions, but in the addons with the support for C++ it needs to be changed to 1 otherwise the exceptions system could be catch the wrong exception.