-
Notifications
You must be signed in to change notification settings - Fork 459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standardize unit test file names #1056
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once commit comment is updated to indicates that all non file-renames are due to fixes issues reported by linter when file was renamed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Could you please add little description about what this PR do. This could help us in the future.
@deepakrkris just waiting for the updates to the comments before landing. |
- change all unit test file names to snake case this helps in parsing file names to tokens and infer metadata like export initializers - all other changes other than file names is due to linter errors
c66e2fa
to
733d91a
Compare
@mhdawson @NickNaso @gabrielschulhof @KevinEady, |
@deepakrkris thanks, landing now |
- change all unit test file names to snake case this helps in parsing file names to tokens and infer metadata like export initializers - all other changes other than file names is due to linter errors PR-URL: #1056 Reviewed-By: Michael Dawson <midawson@redhat.com Reviewed-By: NickNaso <nicoladelgobbo@gmail.com>
Landed as cbac3aa |
- change all unit test file names to snake case this helps in parsing file names to tokens and infer metadata like export initializers - all other changes other than file names is due to linter errors PR-URL: nodejs#1056 Reviewed-By: Michael Dawson <midawson@redhat.com Reviewed-By: NickNaso <nicoladelgobbo@gmail.com>
- change all unit test file names to snake case this helps in parsing file names to tokens and infer metadata like export initializers - all other changes other than file names is due to linter errors PR-URL: nodejs#1056 Reviewed-By: Michael Dawson <midawson@redhat.com Reviewed-By: NickNaso <nicoladelgobbo@gmail.com>
- change all unit test file names to snake case this helps in parsing file names to tokens and infer metadata like export initializers - all other changes other than file names is due to linter errors PR-URL: nodejs/node-addon-api#1056 Reviewed-By: Michael Dawson <midawson@redhat.com Reviewed-By: NickNaso <nicoladelgobbo@gmail.com>
- change all unit test file names to snake case this helps in parsing file names to tokens and infer metadata like export initializers - all other changes other than file names is due to linter errors PR-URL: nodejs/node-addon-api#1056 Reviewed-By: Michael Dawson <midawson@redhat.com Reviewed-By: NickNaso <nicoladelgobbo@gmail.com>
- change all unit test file names to snake case this helps in parsing file names to tokens and infer metadata like export initializers - all other changes other than file names is due to linter errors PR-URL: nodejs/node-addon-api#1056 Reviewed-By: Michael Dawson <midawson@redhat.com Reviewed-By: NickNaso <nicoladelgobbo@gmail.com>
- change all unit test file names to snake case this helps in parsing file names to tokens and infer metadata like export initializers - all other changes other than file names is due to linter errors PR-URL: nodejs/node-addon-api#1056 Reviewed-By: Michael Dawson <midawson@redhat.com Reviewed-By: NickNaso <nicoladelgobbo@gmail.com>
No description provided.