run tests with options to prefix build root path #1055
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepakrkris
force-pushed
the
unit_tests_1016
branch
from
d836a47
to
45f2a55
Compare
mhdawson
reviewed
Aug 27, 2021
test/common/index.js
Outdated
| `../build/${buildType}/binding.node`, | ||
| `../build/${buildType}/binding_noexcept.node`, | ||
| `../build/${buildType}/binding_noexcept_maybe.node`, | ||
| `${relativeBuildPath}../build/${buildType}/binding.node`, |
There was a problem hiding this comment.
Suggestion from @legendecas in Node-api weekly meeting use path.join
There was a problem hiding this comment.
Suggestion from Node-api weekly meeting use "buildPathRoot"
There was a problem hiding this comment.
@legendecas @mhdawson I have added path.join and renamed prefix to "buildPathRoot"
deepakrkris
force-pushed
the
unit_tests_1016
branch
from
45f2a55
to
b79a335
Compare
deepakrkris
changed the title
|
@KevinEady @gabrielschulhof , this PR is ready to review |
mhdawson
pushed a commit
that referenced
this pull request
Sep 10, 2021
PR-URL: #1055 Reviewed-By: Michael Dawson <midawson@redhat.com>
|
Landed as 62b666c |
deepakrkris
pushed a commit
to deepakrkris/node-addon-api
that referenced
this pull request
Sep 23, 2021
PR-URL: nodejs#1055 Reviewed-By: Michael Dawson <midawson@redhat.com>
deepakrkris
pushed a commit
to deepakrkris/node-addon-api
that referenced
this pull request
Oct 15, 2021
PR-URL: nodejs#1055 Reviewed-By: Michael Dawson <midawson@redhat.com>
kevindavies8
added a commit
to kevindavies8/node-addon-api-Develop
that referenced
this pull request
Aug 24, 2022
PR-URL: nodejs/node-addon-api#1055 Reviewed-By: Michael Dawson <midawson@redhat.com>
Marlyfleitas
added a commit
to Marlyfleitas/node-api-addon-Development
that referenced
this pull request
Aug 26, 2022
PR-URL: nodejs/node-addon-api#1055 Reviewed-By: Michael Dawson <midawson@redhat.com>
wroy7860
added a commit
to wroy7860/addon-api-benchmark-node
that referenced
this pull request
Sep 19, 2022
PR-URL: nodejs/node-addon-api#1055 Reviewed-By: Michael Dawson <midawson@redhat.com>
johnfrench3
pushed a commit
to johnfrench3/node-addon-api-git
that referenced
this pull request
Aug 11, 2023
PR-URL: nodejs/node-addon-api#1055 Reviewed-By: Michael Dawson <midawson@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.