Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src,test: Fix up null char * exception thrown #1019

Closed
wants to merge 1 commit into from
Closed

src,test: Fix up null char * exception thrown #1019

wants to merge 1 commit into from

Commits on Jul 9, 2021

  1. src,test: Fix up null char * exception thrown 

    Throw an exception when receiving a null pointer for the `char *` and
`char16_t *` overloads of `String::New` that looks identical to an
error that core would have thrown under the circumstances
(`napi_invalid_arg`).

Also, rename the test methods to conform with our naming convention.
    @gabrielschulhof
    gabrielschulhof committed Jul 9, 2021
    Configuration menu
    Copy the full SHA
    101ccb7 View commit details
    Browse the repository at this point in the history