Major release to drop support for 14.x

[mhdawson]

With Node.js 14.x going EOL today it's time to consider a major in which we'd drop support.

[mhdawson]

Discussed in team meeting today and we should also document the process for dropping support which includes

1. Updating minimum version supported in README.md
2. Removing from GitHub actions
3. Removing from Jenkins CI - https://ci.nodejs.org/view/x%20-%20Abi%20stable%20module%20API/job/node-test-node-addon-api-LTS%20versions/
4. Publishing a major release -https://github.com/nodejs/node-addon-api/blob/main/doc/creating_a_release.md

[mhdawson]

@KevinEady will work on creating the document and then do a release following the doc.

[KevinEady]

Hi team (@NickNaso, @mhdawson, @legendecas , @vmoroz , @JckXia , @gabrielschulhof )

I am working on the release and following Creating a Release. One thing I have a concern about is the final updates to package.json, CHANGELOG.md, README.md prior to NPM publishing.

It looks like for previous releases, these changes were committed directly into main:

• v6.1.0
• v6.0.0
• v5.1.0

I believe these changes should be introduced as a PR. The current workflow with editing main directly only works because we do not have branch protection (which we should have, according to OpenSSF scorecard).

I would like to merge #1324 , then create another PR to perform these final updates. Once that is merged into main, then continue the release/publishing.

How does this sound?

[vmoroz]

@KevinEady, good point! It is better to follow the best practices regarding security.

[KevinEady]

CI for release on 39a25bf:

Version	Job	Status
main	https://ci.nodejs.org/job/node-test-node-addon-api-new/7586/	✅
v20.x	https://ci.nodejs.org/job/node-test-node-addon-api-new/7585/	✅
v18.x	https://ci.nodejs.org/job/node-test-node-addon-api-new/7584/	✅
v16.x	https://ci.nodejs.org/job/node-test-node-addon-api-new/7583/	✅

[KevinEady]

@NickNaso @mhdawson it appears that I do not have access to publish the package on NPM. I have access to the other node-api-header repo (the "Collaborators" on the node-api-header npm page shows my name) but not on node-addon-api npm page

[mhdawson]

@KevinEady what is your npm id? Just want to be sure before I add you :).

[KevinEady]

@KevinEady what is your npm id? Just want to be sure before I add you :).

It's kevineady

[mhdawson]

k invited

[KevinEady]

@mhdawson @NickNaso we are published

➜  node-addon-api-clean git:(main) npm publish
npm notice 
npm notice 📦  node-addon-api@7.0.0
npm notice === Tarball Contents === 
npm notice 1.2kB   LICENSE.md            
npm notice 13.8kB  README.md             
npm notice 762B    common.gypi           
npm notice 560B    except.gypi           
npm notice 306B    index.js              
npm notice 6.3kB   napi-inl.deprecated.h 
npm notice 219.4kB napi-inl.h            
npm notice 115.2kB napi.h                
npm notice 132B    node_api.gyp          
npm notice 639B    noexcept.gypi         
npm notice 0B      nothing.c             
npm notice 467B    package-support.json  
npm notice 10.6kB  package.json          
npm notice 3.2kB   tools/check-napi.js   
npm notice 2.0kB   tools/clang-format.js 
npm notice 15.0kB  tools/conversion.js   
npm notice 2.1kB   tools/eslint-format.js
npm notice 3.2kB   tools/README.md       
npm notice === Tarball Details === 
npm notice name:          node-addon-api                          
npm notice version:       7.0.0                                   
npm notice filename:      node-addon-api-7.0.0.tgz                
npm notice package size:  59.9 kB                                 
npm notice unpacked size: 395.0 kB                                
npm notice shasum:        8136add2f510997b3b94814f4af1cce0b0e3962e
npm notice integrity:     sha512-vgbBJTS4m5/Kk[...]uBQj9rJ/Ho0ZA==
npm notice total files:   18                                      
npm notice 
npm notice Publishing to https://registry.npmjs.org/
This operation requires a one-time password.
Enter OTP: xxxxxx
+ node-addon-api@7.0.0

According to Creating a Release, the next step is:

Tweet that the release has been created.

I don't have Twitter, if someone else wants to do this part i'd be grateful 👍

Closing issue!

[mhdawson]

@KevinEady Is this still to be done ?

I would like to merge #1324 , then create another PR to perform these final updates. Once that is merged into main, then continue the release/publishing.

As we don't seem to have a 7.0.0 release in the repo?

[KevinEady]

Create a release in Github (look at existing releases for an example).

🤦

This has now been completed: https://github.com/nodejs/node-addon-api/releases/tag/v7.0.0

EDIT:

@KevinEady Is this still to be done ?

I would like to merge #1324 , then create another PR to perform these final updates. Once that is merged into main, then continue the release/publishing.

This was completed prior to release.