Skip to content

Provide a new Buffer::NewOrCopy method #1257

Closed
@Julusian

Description

@Julusian

Background:

After nodejs/node#45181 it is possible for Buffer::new to fail with napi_no_external_buffers_allowed. A helper method Buffer::NewOrCopy which would try to do a Buffer::new and fallback to doing a Buffer::copy would be helpful and encourage users to code in a way which provides compatibility for both electron and nodejs, without them having to implement the method themselves.

The npm package sharp has implemented this themselves already lovell/sharp@584807b#diff-53a01d31aa585021f8f316c6613dadef86bf1f9ac2070d52daa68adbefbb6ef4.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions