Skip to content

fix: handle removed IdleNotificationDeadline #999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: handle removed IdleNotificationDeadline #999

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion nan.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -701,7 +701,14 @@ inline uv_loop_t* GetCurrentEventLoop() {
NAN_DEPRECATED inline bool IdleNotification(int) {
return true;
}
# elif defined(V8_MAJOR_VERSION) && (V8_MAJOR_VERSION > 4 || \
#elif defined(V8_MAJOR_VERSION) && (V8_MAJOR_VERSION > 12 || \
(V8_MAJOR_VERSION == 12 && defined(V8_MINOR_VERSION) && V8_MINOR_VERSION >= 7))
inline bool IdleNotification(int idle_time_in_ms) {
v8::Isolate::GetCurrent()->MemoryPressureNotification(
v8::MemoryPressureLevel::kModerate);
return true;
}
#elif defined(V8_MAJOR_VERSION) && (V8_MAJOR_VERSION > 4 ||
(V8_MAJOR_VERSION == 4 && defined(V8_MINOR_VERSION) && V8_MINOR_VERSION >= 3))
NAN_DEPRECATED inline bool IdleNotification(int idle_time_in_ms) {
return v8::Isolate::GetCurrent()->IdleNotificationDeadline(
Expand Down
Loading