remove usage of deprecated IsNearDeath#842
Merged
kkoopa merged 1 commit intonodejs:masterfrom Mar 24, 2019
Flarna:no-isneardeath
Merged
remove usage of deprecated IsNearDeath#842kkoopa merged 1 commit intonodejs:masterfrom Flarna:no-isneardeath
kkoopa merged 1 commit intonodejs:masterfrom
Flarna:no-isneardeath
Conversation
bnoordhuis
approved these changes
Mar 15, 2019
Member
bnoordhuis
left a comment
bnoordhuis
left a comment
There was a problem hiding this comment.
LGTM. CI failure appears to be infrastructural (fails to download headers.)
Contributor
|
I would love to see this change merged into master (if possible). PersistentBase::IsNearDeath() has been removed in the version of v8 used in the v8-canary build of Node 12, and it would be nice to be able to test with the v8-canary build with the version of nan that can be installed from github. |
Member
|
@kkoopa See above. Do you want to do a release for this? It's an otherwise harmless change. |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove use of
PersistentBase::IsNearDeath()as it has been deprecated in V8 and it would causes compilation warnings in Node.JS 12.I have not added any
ifdefshere as it was used only withinasserts.Refs: nodejs/node#26630