AsyncResource: Local param instead of MaybeLocal

[ofrobots]

No need to use a MaybeLocal. It is possible to pass an empty Local
to indicated that an object should be allocated automatically.

[kkoopa]

Windows builds are currently failing due to a couple (unrelated) things in two new tests from the previous PRs: https://ci.appveyor.com/project/RodVagg/nan/build/job/8vx1q4hhlnetncsi

test\cpp\callbackcontext.cpp(38): error C2466: cannot allocate an array of constant size 0
test\cpp\asyncresource.cpp(41): error C2466: cannot allocate an array of constant size 0

Please pass null instead. You can add the commit here if you like.

[ofrobots]

Fixed the windows build.

[kkoopa]

Ah, nevermind then. All tests seem to pass on all platforms now. I will merge this later today.

…

On February 13, 2018 5:26:42 PM GMT+02:00, Ali Ijaz Sheikh ***@***.***> wrote: ofrobots commented on this pull request. > #if NODE_MODULE_VERSION >= NODE_8_0_MODULE_VERSION v8::Isolate* isolate = v8::Isolate::GetCurrent(); - v8::Local<v8::Object> resource = - maybe_resource.IsEmpty() ? New<v8::Object>() - : maybe_resource.ToLocalChecked(); + if (resource.IsEmpty()) { + resource = New<v8::Object>(); + } An empty handle is not the same as a handle pointing to a newly allocated object. ```c++ Local<v8::Object> handle1; Local<v8::Object> handle2 = New<v8::Object>(); assert(handle1.IsEmpty() == true); assert(handle2.IsEmpty() == false); ```