Skip to content

Add Function::Call wrapper - #496

Closed
kkoopa wants to merge 1 commit into
nodejs:masterfrom
kkoopa:functioncall
Closed

kkoopa wants to merge 1 commit into
nodejs:masterfrom
kkoopa:functioncall

Conversation

@kkoopa

@kkoopa kkoopa commented Oct 15, 2015

Copy link
Copy Markdown
Collaborator

No description provided.

@kkoopa kkoopa added this to the 2.2 milestone Oct 15, 2015
@joshperry

Copy link
Copy Markdown

I'm using this code in a project and somewhere between v0.10 and v0.12 the recv parameter was changed from Object to Value. I'm going to change the parameter type in the pre_46 ifdef in my code, but I'm not familiar enough with the progression of v8/node to know if that's enough.

Do you know if this ifdef needs to be modified slightly to build properly on v0.12?

@kkoopa

kkoopa commented Oct 16, 2015

Copy link
Copy Markdown
Collaborator Author

No, Object is a descendant of Value. I've updated the branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants